Skip to content

fix the conditional logic for creating the empty selfsigned issuer #321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
qrkourier merged 2 commits into from
Mar 28, 2025
Merged

fix the conditional logic for creating the empty selfsigned issuer #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4d9c23
fix the conditional logic for creating the empty selfsigned issuer
qrkourier Mar 27, 2025
0fddbdd
finish testing miniziti
qrkourier Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/miniziti.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,7 @@ jobs:
- name: install miniziti
uses: supplypike/setup-bin@v4
with:
# uri: https://get.openziti.io/miniziti.bash
uri: https://raw.githubusercontent.com/openziti/ziti/refs/heads/quick-k8s-helm-deps/quickstart/kubernetes/miniziti.bash
uri: https://get.openziti.io/miniziti.bash
name: miniziti
version: quickstartrelease

Expand Down
4 changes: 2 additions & 2 deletions charts/ziti-controller/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: 1.4.2
appVersion: 1.5.3
dependencies:
- condition: cert-manager.enabled
name: cert-manager
Expand All @@ -16,4 +16,4 @@ dependencies:
description: Host an OpenZiti controller in Kubernetes
name: ziti-controller
type: application
version: 1.2.2
version: 1.3.0
2 changes: 1 addition & 1 deletion charts/ziti-controller/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# ziti-controller

![Version: 1.2.2](https://img.shields.io/badge/Version-1.2.2-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.4.2](https://img.shields.io/badge/AppVersion-1.4.2-informational?style=flat-square)
![Version: 1.3.0](https://img.shields.io/badge/Version-1.3.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.5.3](https://img.shields.io/badge/AppVersion-1.5.3-informational?style=flat-square)

Host an OpenZiti controller in Kubernetes

Expand Down
6 changes: 2 additions & 4 deletions charts/ziti-controller/templates/ca-selfsigned-issuer.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
# generate a self-signed issuer if no alternative issuer is configured for the controller's
# control plane and web binding PKIs
{{- if and (eq (len .Values.ctrlPlane.alternativeIssuer) 0) (eq (len .Values.webBindingPki.alternativeIssuer) 0) }}
# generate an empty Issuer for creating root CAs unless all the controller's other PKIs are configured with an alternative issuer
{{- if or (eq (len .Values.ctrlPlane.alternativeIssuer) 0) (eq (len .Values.webBindingPki.alternativeIssuer) 0) (eq (len .Values.edgeSignerPki.alternativeIssuer) 0) }}
---
# an 'empty' Issuer for creating self-signed root-CA's
apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
Expand Down