Skip to content

Comments

Configurable migrate job image and disable migration resources if persisted identity exists#365

Closed
rndmit wants to merge 2 commits intoopenziti:mainfrom
rndmit:feature/job-image
Closed

Configurable migrate job image and disable migration resources if persisted identity exists#365
rndmit wants to merge 2 commits intoopenziti:mainfrom
rndmit:feature/job-image

Conversation

@rndmit
Copy link

@rndmit rndmit commented Sep 23, 2025

This PR makes it possible to override the migration job image and fixes the unnecessary creation of migration resources (such as PVC) if the identity is set by .Values.secret.existingSecretName


migrateJobImage:
registry: docker.io
repository: portainer/kubectl-shell
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, is portainer/kubectl-shell a superior image in general, or specifically for this scenario, than bitnami/kubectl, or preferred for some other reason? I'm not strongly opinionated and hope to gain your insight on this.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's actually not. But it was the first one I found with bash installed.
And if your question is about "why it was changed?" - because of this: bitnami/containers#83267 (tldr; bitnami catalog will be deprecated soon)

@qrkourier
Copy link
Member

qrkourier commented Sep 23, 2025

This reminded me about a problem report: #338

The solution is to refactor the ZET chart (the node proxy daemonset) to delete the migration job, which is no longer relevant, clarify the two deployment modes (identity in writable PVC vs. existing read-only secret), and stop hard-coding the PVC access mode, since it must be RWX if there's more than one cluster worker node. Pull request on-the-way.

@qrkourier qrkourier closed this Sep 23, 2025
@rndmit
Copy link
Author

rndmit commented Sep 30, 2025

Hello again,
Just wanted to ask: how soon will it be ready?
There is no more bitnami/kubectl:latest image. So, the current version of chart is not working.

@qrkourier
Copy link
Member

@rndmit Since the ZET 1.2.0 chart was broken when Bitnami decommissioned the kubectl image, I have released the ZET 1.3.0 chart immediately and will begin testing. Please raise a GH issue if you find a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants