Add option for disabling CAs bundle creation#366
Open
rndmit wants to merge 3 commits intoopenziti:mainfrom
Open
Add option for disabling CAs bundle creation#366rndmit wants to merge 3 commits intoopenziti:mainfrom
rndmit wants to merge 3 commits intoopenziti:mainfrom
Conversation
Member
|
It appears to be a good, simple solution to the problem of competing Trust Manager instances, which cannot be namespaced. We need to test this to ensure it's reverse compatible and provides a continually updated trust bundle. At least, the bundle written to the bundle must update when the pod starts, in case a new controller node has been added to the cluster. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds option
.Values.ctrlPlaneCasBundle.enabledwhich toggles trust-manager Bundle creation. If it is set tofalse, then CAs bundle will be created in init-container.I personally need this feature because trust-manager is already used in our clusters and we're not able to dedicate it to ziti-controller.