Skip to content

Comments

angular upgrade to 20#799

Merged
rgallettonf merged 30 commits intomainfrom
v19_ang_upg
Feb 23, 2026
Merged

angular upgrade to 20#799
rgallettonf merged 30 commits intomainfrom
v19_ang_upg

Conversation

@vickynf
Copy link
Contributor

@vickynf vickynf commented Jan 23, 2026

fix #811

angular upgrade to 20

@vickynf vickynf requested review from a team as code owners January 23, 2026 14:51
@vercel
Copy link

vercel bot commented Jan 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ziti-console Ready Ready Preview, Comment Feb 23, 2026 10:49am

Request Review

@vickynf vickynf marked this pull request as draft January 23, 2026 14:53
@vickynf vickynf requested a review from rgallettonf January 23, 2026 14:54
@rgallettonf
Copy link
Contributor

rgallettonf commented Jan 26, 2026

Pulled down changes and have some notes:

Functionally everything seems to work ok, there a just a handful of issues I've found in testing so far that I've noted below:

  • Currently required to use --force or --legacyPeerDeps on npm install

  • Date picker filter for table needs some styling love. It should open as a popup when filtering from the data table, but it currently displays above the table and pushing things down when it's visible. Also looks like it may be missing some icons.

Screenshot 2026-01-26 at 7 50 53 AM
  • Filter Select/Dropdown component has some styling/consistency issues from the previous component to the new one:
    • The close button look
Screenshot 2026-01-26 at 7 41 44 AM s like it's showing some kind of text instead of an icon
  • There seems to be some border and background styling being applied that is a little inconsistent with the previous component
Screenshot 2026-01-26 at 7 44 41 AM Screenshot 2026-01-26 at 7 43 49 AM

@vickynf
Copy link
Contributor Author

vickynf commented Feb 3, 2026

@rgallettonf please see I have pushed all changes that can resolve the issues.

  1. For Currently required to use --force or --legacyPeerDeps on npm install ---> this i will remove when we move version 20
    Please review all.

@vickynf vickynf marked this pull request as ready for review February 16, 2026 09:12
@vickynf vickynf changed the title angular upgrade to 19 and replace the primng comp angular upgrade to 20 Feb 18, 2026
@rgallettonf
Copy link
Contributor

rgallettonf commented Feb 20, 2026

@vickynf still seeing some slightly odd styling for the type ahead dropdown filter. Looks like there is a thin dark blue line that is showing in the base of the component and the padding around the search field is a little "off", also the border of the dropdown container looks like it's squared (no border radius), and also lays over top the input. See screeenshot below:
new-dropdown

Also looks like the left/right padding is a little bit thicker than the previous component.

previous component for comparison:

Screenshot 2026-02-20 at 12 47 44 AM

@vickynf
Copy link
Contributor Author

vickynf commented Feb 23, 2026

Resolved

@vickynf vickynf reopened this Feb 23, 2026
@rgallettonf rgallettonf merged commit ba0ddd7 into main Feb 23, 2026
11 checks passed
@rgallettonf rgallettonf deleted the v19_ang_upg branch February 23, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

angular upgrade to 20

2 participants