Skip to content

🌱 fix(release) Issues faced with invalid latest tag after changes in goreleaser#1901

Merged
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
camilamacedo86:fix-release
Feb 4, 2026
Merged

🌱 fix(release) Issues faced with invalid latest tag after changes in goreleaser#1901
openshift-merge-bot[bot] merged 1 commit intooperator-framework:masterfrom
camilamacedo86:fix-release

Conversation

@camilamacedo86
Copy link
Contributor

@camilamacedo86 camilamacedo86 commented Feb 4, 2026

The Docker build command was generating malformed tags where the image repository was being duplicated in the tag field:

  • quay.io/operator-framework/opm:quay.io/operator-framework/opm:latest
  • quay.io/operator-framework/opm:latest (expected)

Full run: https://github.com/operator-framework/operator-registry/actions/runs/21664023146/job/62457874146

Root Cause

When the project migrated to GoReleaser v2.12 (PR #1891, commit 4e96664), the way Docker image tags are constructed changed:

GoReleaser v1 behavior:

  • Required full image references in tag variables
  • Example: LATEST_IMAGE_OR_EMPTY=quay.io/operator-framework/opm:latest

GoReleaser v2 behavior:

  • Automatically combines images field with tags field
  • Tag variables should only contain the tag portion
  • Example: LATEST_IMAGE_OR_EMPTY=latest

The Makefile was still using the v1 format, causing GoReleaser v2 to combine:

  • Image: quay.io/operator-framework/opm
  • Tag: quay.io/operator-framework/opm:latest
  • Result: quay.io/operator-framework/opm:quay.io/operator-framework/opm:latest

Solution

Updated the Makefile to export only tag names (without the image repository) in:

  1. LATEST_IMAGE_OR_EMPTY variable (line 145)

    • Changed from: echo "$(OPM_IMAGE_REPO):latest"
    • Changed to: echo "latest"
  2. tagged-or-empty function (line 176)

    • Changed from: echo "$(OPM_IMAGE_REPO):$(1)"
    • Changed to: echo "$(1)"

This ensures GoReleaser v2 correctly combines the image repository with tag names to produce valid Docker tags.

Related

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.48%. Comparing base (fa08e28) to head (4dc8094).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1901   +/-   ##
=======================================
  Coverage   57.48%   57.48%           
=======================================
  Files         138      138           
  Lines       13307    13307           
=======================================
  Hits         7649     7649           
  Misses       4476     4476           
  Partials     1182     1182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@perdasilva
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 4, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perdasilva

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 4, 2026
Copy link
Contributor

@oceanc80 oceanc80 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 4, 2026
@openshift-merge-bot openshift-merge-bot bot merged commit f8e92c4 into operator-framework:master Feb 4, 2026
13 checks passed
@camilamacedo86 camilamacedo86 deleted the fix-release branch February 4, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants