Skip to content

Conversation

@Xia-Zhao-rh
Copy link

Description of the change:

The GetRelease() function previously failed when the release field in a CSV spec was specified as a numeric value (e.g., release: 0.20250104) instead of a string. This occurred because YAML parsers treat values starting with digits as numbers, and the function attempted to unmarshal directly into a string type, causing a type mismatch error.

Modified GetRelease() to first unmarshal into an interface{} type, then convert to string using fmt.Sprintf(), allowing it to handle both string and numeric release values.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 5, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Feb 5, 2026

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.44%. Comparing base (9fa4d9b) to head (7f67d7a).
⚠️ Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/registry/csv.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1904   +/-   ##
=======================================
  Coverage   57.44%   57.44%           
=======================================
  Files         139      139           
  Lines       13323    13323           
=======================================
  Hits         7653     7653           
  Misses       4488     4488           
  Partials     1182     1182           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Xia-Zhao-rh
Copy link
Author

/close

@openshift-ci openshift-ci bot closed this Feb 6, 2026
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 6, 2026

@Xia-Zhao-rh: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant