Draft
Conversation
ogenstad
commented
Jun 9, 2025
| {%- endmacro -%} | ||
| {%- if data is defined %} | ||
| {{ render_interfaces(data.InfraInterface.edges) }} | ||
| {% endif %} No newline at end of file |
Contributor
Author
There was a problem hiding this comment.
Without this conditional if-statement all the rendering of the base template fails because data is not defined. Another approach to this would be to place all macros in a separate file. Though in that case this stand-alone interface template would only import the macro and then render the macro.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides an alternate approach to #46, with the difference being that we use Jinja2 macros that are imported from another file. During testing I noticed that Jinja2 tries to render the content of the template from where we import the macro when importing a macro in this way. However the context with the provided data seems to differ so I've added a workaround in the interface template where we check to see if the
datavariable is defined.