Skip to content

Comments

feat: add allow_override parameter to registration methods#15

Merged
snuffkin merged 6 commits intooqtopus-team:mainfrom
yasuhito:feature/add-allow-override-parameter
Dec 21, 2024
Merged

feat: add allow_override parameter to registration methods#15
snuffkin merged 6 commits intooqtopus-team:mainfrom
yasuhito:feature/add-allow-override-parameter

Conversation

@yasuhito
Copy link
Contributor

@yasuhito yasuhito commented Dec 20, 2024

✍ Description

This PR adds the allow_override parameter to all registration methods in the Tranqu class to provide consistent control over registration overrides. The following methods have been updated:

  • register_program_converter
  • register_device_converter
  • register_program_type
  • register_device_type

Each method now accepts an optional allow_override parameter (defaults to False) that controls whether existing registrations can be overwritten.

@yasuhito yasuhito marked this pull request as draft December 20, 2024 07:09
@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Files with missing lines Coverage Δ
src/tranqu/device_converter/__init__.py 100.00% <ø> (ø)
...ranqu/device_converter/device_converter_manager.py 100.00% <100.00%> (+14.81%) ⬆️
src/tranqu/device_type_manager.py 100.00% <100.00%> (ø)
...nqu/program_converter/program_converter_manager.py 100.00% <100.00%> (ø)
src/tranqu/program_type_manager.py 100.00% <100.00%> (ø)
src/tranqu/tranqu.py 98.21% <100.00%> (ø)
src/tranqu/transpiler/transpiler_manager.py 100.00% <100.00%> (ø)

@yasuhito yasuhito changed the title feat: Add allow_override parameter feat: add allow_override parameter to registration methods Dec 20, 2024
@yasuhito yasuhito marked this pull request as ready for review December 20, 2024 08:23
Copy link
Contributor

@snuffkin snuffkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@snuffkin snuffkin merged commit 18e9b8b into oqtopus-team:main Dec 21, 2024
4 of 5 checks passed
@snuffkin snuffkin added the feature Adding a new feature label Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Adding a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants