WIP: Make visible cursor in search field move with index (fix #92)#93
Open
lukeflo wants to merge 1 commit intoorhun:mainfrom
Open
WIP: Make visible cursor in search field move with index (fix #92)#93lukeflo wants to merge 1 commit intoorhun:mainfrom
lukeflo wants to merge 1 commit intoorhun:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #93 +/- ##
========================================
+ Coverage 3.31% 3.32% +0.01%
========================================
Files 19 19
Lines 2417 2414 -3
========================================
Hits 80 80
+ Misses 2337 2334 -3 ☔ View full report in Codecov by Sentry. |
Owner
|
Thanks for the PR! It looks good to me.
Yeah, I took a quick look and couldn't figure out what's wrong. FWIW, I did a similar implementation in
I'm not sure how that's related, can you explain a bit more? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of change
I made the visible cursor move with the index of the current search pattern using the
visual_cursor()andvisual_scrollmethod of thetui_inputcrate. It works now, but the cursor still hides the underlaying character. Maybe the order of the innerrenderfunctions for each tab has to be changed (at least that worked in my own tui app). But your rendering code is quite complex and I hadn't the time to skim through all details.Though, I still hope this WIP PR helps with the issue.