add parameter ignoreReadMethod in ObjectPropertyAccessor#313
Merged
lukaszlenart merged 2 commits intoorphan-oss:mainfrom Dec 27, 2024
Merged
add parameter ignoreReadMethod in ObjectPropertyAccessor#313lukaszlenart merged 2 commits intoorphan-oss:mainfrom
lukaszlenart merged 2 commits intoorphan-oss:mainfrom
Conversation
lukaszlenart
approved these changes
Dec 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current implementation of getting property using
ObjectPropertyAccessorwill firstly try to find get method of target property,if no get method found then try to find read method. If read method exist returns the return value of the read method。Sometimes read method does not directly returns the value of property. For example the class
org.apache.kafka.clients.consumer.internals.Fetcher, it has a propertycompletedFetches, and a methodhasCompletedFetcheswhich will be recognized as a read method of the propertycompletedFetches, it returns a boolean value instead of the actural value ofcompletedFetches. But what I need is to get the elements of ConcurrentLinkedQueue. So I think we should offer a parameter to ignore detecting read method in this case.