Skip to content

Removed duplic#59

Open
Ronniedeveloper wants to merge 4 commits intooscakampala:mainfrom
Ronniedeveloper:bugFixe2
Open

Removed duplic#59
Ronniedeveloper wants to merge 4 commits intooscakampala:mainfrom
Ronniedeveloper:bugFixe2

Conversation

@Ronniedeveloper
Copy link

Removed duplicate classes from the homepage of mx-auto

@netlify
Copy link

netlify bot commented May 21, 2023

Deploy Preview for aquamarine-haupia-c31c21 ready!

Name Link
🔨 Latest commit 702198c
🔍 Latest deploy log https://app.netlify.com/sites/aquamarine-haupia-c31c21/deploys/646ca895f14de30008b7cf0f
😎 Deploy Preview https://deploy-preview-59--aquamarine-haupia-c31c21.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

</div>
<h1 className='px-5 text-3xl md:mt-10'>
Join a Large Growing Community in Town
Join a Large Open Source Growing Community in Town
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ronniedeveloper how if we had this wording as

Suggested change
Join a Large Open Source Growing Community in Town
Join a Large Growing Open Source Community in Town

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this suggestion 💯

</div>

<div className='container mx-auto mt-20 max-w-6xl mx-auto'>
<div className='container mx-auto mt-20 max-w-6xl'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this:clap:

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome 🤗

<button
type='submit'
className='mt-12 w-full md:w-36 rounded-md py-3 capitalize bg-[#5A75AB] text-white font-bold tracking-wider'>
className='mt-12 w-full md:w-36 rounded-md shadow-md hover:shadow-xl py-3 capitalize bg-[#5A75AB] text-white font-bold tracking-wider'>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good...this helps us keep consistency with other buttons such as those in navbar

"scripts": {
"dev": "next dev",
"build": "next build",
"export": "next export",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ronniedeveloper why are these scripts being removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ronniedeveloper please make this adjustment and all will be well with this PR


<h1>Experience page</h1>
<div className="container mx-9 py-4 md:mt-10 sm:mt-5">
<h1>Experience page</h1>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for this 👏

pages/index.jsx Outdated
className='container mx-auto w-[100%] md:w-[85%] sm:w-[90%]'
width='560'
height='315'
height='335'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i still feel like we need to increase the height...

@HassanBahati
Copy link
Contributor

please resolve the conflicts this branch has with main

"scripts": {
"dev": "next dev",
"build": "next build",
"export": "next export",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ronniedeveloper please make this adjustment and all will be well with this PR

@HassanBahati
Copy link
Contributor

Hi @Ronniedeveloper , thank you for sparing time to contribute. Much appreciated 👏
Though there are some conflicts. Kindly attend to the conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants