[FEAT] Add models, URLs, and CRUD endpoints for handling achievements of political figures#25
Open
Appyouz wants to merge 2 commits intoosnepal:mainfrom
Open
[FEAT] Add models, URLs, and CRUD endpoints for handling achievements of political figures#25Appyouz wants to merge 2 commits intoosnepal:mainfrom
Appyouz wants to merge 2 commits intoosnepal:mainfrom
Conversation
- Implements full CRUD for the new Achievement model with custom year validation. - Secures all modification actions (POST/PATCH/DELETE) using the new IsAdminOrSuper permission. - Restructures the political_figure app, splitting models and views into core/ and feature specific files.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request (PR) is to add the Achievement models, serializers, views, and URLs to handle achievements for political figures. This work closes #13.
I followed the plan to split up the files and add the new models and endpoints.
File Changes
Models Split:
Replaced
political_figure/models.pywith new files:political_figure/models/__init__.py(just for importing everything)political_figure/models/core.py(has the existingPoliticalFiguremodel)political_figure/models/achievements.py(New file for theAchievementmodel)Views Split:
Replaced
political_figure/views.pywith new files:political_figure/views/__init__.py(just for importing everything)political_figure/views/core.py(has the existing views)political_figure/views/achievements.py(New file for the achievement views)New Model:
AchievementI made a new model in
political_figure/models/achievements.py. It inherits fromBaseModel.political_figureForeignKeytitleCharFieldcategoryTextChoicesdescriptionTextFieldyearIntegerFieldawarding_bodyCharFieldevidence_linkURLFieldstatusTextChoicesSerializer and Validation
I created the
AchievementSerializer.I also added a custom validation in the serializer for the
yearfield to make sure people enter a proper 4-digit year (like2025AD or2082BS) and not something too short or too long.