replace polyvox with simpler implementation #2026
Open
+955
−428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RTUnreal
added
needs CR
ksuprynowicz
requested changes
Jan 25, 2026
Member
ksuprynowicz
left a comment
ksuprynowicz
left a comment
There was a problem hiding this comment.
Thank you! Everything looks good :)
I only have minor feedback about some of the formatting changes, let me know what you think about it.
libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp
Outdated
Show resolved
Hide resolved
libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp
Outdated
Show resolved
Hide resolved
libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp
Outdated
Show resolved
Hide resolved
libraries/entities-renderer/src/RenderablePolyVoxEntityItem.cpp
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces the functionality of the polyvox library, so we don't have to ship it anymore. :)
This will to introduce a bit of a breaking change, where if borders are filled in, then the faces at the border is not rendered. But considering, that polyvox already did it at some of the sides, I tought it would be better to always not render faces there, so that tiling can be done in the future. This can be changed back if needed