fix: cppcheck warnings, cppcheck 2.19.0#3485
Merged
airween merged 2 commits intoowasp-modsecurity:v3/masterfrom Jan 23, 2026
Merged
fix: cppcheck warnings, cppcheck 2.19.0#3485airween merged 2 commits intoowasp-modsecurity:v3/masterfrom
airween merged 2 commits intoowasp-modsecurity:v3/masterfrom
Conversation
|
There was a problem hiding this comment.
Pull request overview
This PR addresses cppcheck 2.19.0 warnings by improving const-correctness and preventing unwanted object copying in classes with resource management.
Changes:
- Added deleted copy constructors and assignment operators to six classes that manage dynamic resources
- Made pointer parameters const in two functions that only read from rule objects
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/engine/lua.h | Added deleted copy/assignment operators to LuaScriptBlob class which manages dynamic memory |
| src/operators/pm.h | Added deleted copy/assignment operators to Pm class which manages ACMP resources |
| src/operators/rx.h | Added deleted copy/assignment operators to Rx class which manages Regex resources |
| src/operators/rx_global.h | Added deleted copy/assignment operators to RxGlobal class which manages Regex resources |
| src/request_body_processor/multipart.h | Added deleted copy/assignment operators to Multipart class which manages resources |
| src/utils/ip_tree.h | Added deleted copy/assignment operators to IpTree class which manages tree resources |
| src/variables/rule.h | Made pointer parameters and local variables const in id() and severity() functions which only read from rules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what
This PR fixes a few
cppcheckwarnings:src/engine/lua.h: added copy and=operator constructorssrc/operators/pm.h: added copy and=operator constructorssrc/operators/rx.h: added copy and=operator constructorssrc/operators/rx_global.h: added copy and=operator constructorssrc/request_body_processor/multipart.h: added copy and=operator constructorssrc/utils/ip_tree.h: added copy and=operator constructorssrc/variables/rule.h: change pointer declarations toconstwhere it's possiblewhy
After a recently merged PR I got a notification about a failed test.
I downloaded the report and found these issues:
references
cppcheck new version (2.19.0) was released on 2025.12.21, see the release page. This new version was probably released into the GH workflow later than the mentioned PR was (2025.12.28).