Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Can't repro locally, but this happened twice in CI so it's probably not a fluke. 
|
app/pages/system/AuditLog.tsx
Outdated
| export const handle = { crumb: 'Audit Log' } | ||
|
|
||
| // todo | ||
| // might want to still render the items in case of error |
There was a problem hiding this comment.
Probably, we could just add a banner and a refresh. What type of error could we expect here? If you were no longer authorised you'd be logged out? Just a general server error retrieving?
There was a problem hiding this comment.
Errors should be pretty unlikely if you can get to the page at all, so I’d say keep it very generic.
app/pages/system/AuditLog.tsx
Outdated
| return <div>Error State</div> | ||
| } | ||
|
|
||
| // todo |
There was a problem hiding this comment.
I think I'll do a skeleton state that is essentially a bunch of empty items to avoid too much layout shift when they load
|
I don't like how the JSON causes the rest of the items to move. Even with virtualisation and a few optimisations it all takes too long to render. I want to have another stab at the JSON preview design but it should be detached from the main list to have it feeling snappier. Will also work on the skeleton and error states. |
|
Some provisional designs for: Error State Loading State View Log Row Focus |
2 participants
Copied from #2849, which I accidentally merged and couldn't reopen even after I fixed
main.Still very rough, but has been a helpful exercise in working through some of the design due to the sheer amount of information and differing layout from other pages.
Stubbing out based on oxidecomputer/omicron#7339.
Uses Tanstack Virtual. On testing with > 500 lines without virtualisation it starts to get a bit chunky especially if you're interacting with the page (e.g. opening the row).
Hoping that silo name and actor display name can be plumbed through so those are hard-coded for now.
Still needs: