Draft
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
david-crespo
commented
Jan 21, 2026
| setTimeout(() => { | ||
| document.hasFocus = originalHasFocus | ||
| }, 50) | ||
| }) |
Collaborator
Author
There was a problem hiding this comment.
This is really contrived, but it does fail without the fix in exactly the way you'd expect, and it passes with the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3012
Was curious how Claude would handle this. It cost $1.31. It did not get it until I explained that in the video, we do not see the list options close, we only see the typed-in query disappear. I've confirmed by hand that the fix does appear to work.
Claude's explanation:
Just putting this up to look into more later. I want to look into this behavior of Headless, calling
onCloseon blur. I don't understand why we don't see the options list close too. I'm also skeptical that adding 4 seconds worth of tests to the e2e suite is worth it for this one thing — maybe we do need something faster than playwright for component-level tests now that they're so cheap to write. We could have hundreds of them.