Conversation
Added a new `oxide-nic-ip` string flag to configure the IP address for the instance's network interface. Perhaps there's an opportunity here to create flags that allow users to specify multiple network interfaces, but that can be a follow-up item if there are use cases for that. This change was introduced because there were cases where an instance's network interface would not be assigned an IP address unless the IP address was explicitly specified even though the underlying subnet had available IP addresses for use.
Collaborator
Author
|
Note to self. Don't submit draft pull requests before eating breakfast haha. This change would work for a single node managed by the node driver but doesn't work when using node pools to manage multiple nodes. That's because the node pool calls the node driver with a static state (e.g., use VPC X) rather than a per-node state (e.g., use IP X). This change would result in all nodes in a node pool trying to use the same IP address, which is obviously incorrect. Closing this for now but will keep the learning in mind. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new
oxide-nic-ipstring flag to configure the IP address for the instance's network interface. Perhaps there's an opportunity here to create flags that allow users to specify multiple network interfaces, but that can be a follow-up item if there are use cases for that.This change was introduced because there were cases where an instance's network interface would not be assigned an IP address unless the IP address was explicitly specified even though the underlying subnet had available IP addresses for use.