Skip to content

Conversation

@Alhanaqtah
Copy link
Contributor

@Alhanaqtah Alhanaqtah commented Jan 4, 2026

Description

The tests have been finalized to use the new API (b.Loop()). Also, the dependence on b.N in determining the size of the generated data has been eliminated.


  • I have read and followed all requirements in CONTRIBUTING.md;
  • I used LLM/AI assistance to make this pull request;

If you have used LLM/AI assistance please provide model name and full prompt:

Model: {{model-name}}
Prompt: {{prompt}}

@Alhanaqtah Alhanaqtah changed the base branch from 263-tidy-up-benchmarks to main January 11, 2026 08:54
@dkharms
Copy link
Member

dkharms commented Jan 20, 2026

@Alhanaqtah hey! Sorry for a quite late answer.

Could you please fix issues I've left and also do following:

  • fix pull request title (you can find rules in contribution guidelines);
  • remove Fixes #263 line from description - I want do add new benchmarks as a part of this issue;

@Alhanaqtah Alhanaqtah changed the title benchmarks tidied up refactor: benchmarks tidied up Jan 24, 2026
@Alhanaqtah Alhanaqtah force-pushed the 263-tidy-up-benchmarks branch from c941078 to c63dcd7 Compare January 25, 2026 08:26
@Alhanaqtah Alhanaqtah force-pushed the 263-tidy-up-benchmarks branch from c63dcd7 to ccdaa3b Compare January 25, 2026 16:39
@Alhanaqtah Alhanaqtah force-pushed the 263-tidy-up-benchmarks branch from ccdaa3b to 8da327c Compare January 25, 2026 16:41
@Alhanaqtah Alhanaqtah requested a review from dkharms January 25, 2026 16:42
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.53%. Comparing base (5b4cce1) to head (02517f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #308      +/-   ##
==========================================
- Coverage   71.61%   71.53%   -0.08%     
==========================================
  Files         204      204              
  Lines       14767    14648     -119     
==========================================
- Hits        10575    10479      -96     
+ Misses       3439     3419      -20     
+ Partials      753      750       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Alhanaqtah Alhanaqtah requested a review from dkharms January 26, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants