Skip to content

only build tests with nanomsg and thrift #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
grg merged 1 commit into from
Jan 22, 2026
Merged

only build tests with nanomsg and thrift #1335

grg merged 1 commit into from
Jan 22, 2026

Conversation

@grg
Copy link
Contributor

@grg grg commented Jan 22, 2026

Don't attempt to build tests dir unless nanomsg and thrift are being used. The test binaries depend on libbmapps, which in turn needs nanomsg.

Fixes #1310

@grg
only build tests with nanomsg and thrift
41a2468 
Don't attempt to build tests dir unless nanomsg and thrift are being
used.  The test binaries depend on libbmapps, which in turn needs
nanomsg.

Fixes p4lang#1310

Signed-off-by: Glen Gibb <gleng@ai-fabrics.com>
@grg grg mentioned this pull request Jan 22, 2026
Closed
@grg
Copy link
Contributor Author

grg commented Jan 22, 2026

@fruffy test-ubuntu22 build is failing with the message below. How do we fix this?

Err:8 http://download.opensuse.org/repositories/home:/p4lang/xUbuntu_22.04  InRelease
  The following signatures were invalid: EXPKEYSIG A4666B6753C0F7D1 home:p4lang OBS Project <home:p4lang@build.opensuse.org>
Reading package lists...
W: GPG error: http://download.opensuse.org/repositories/home:/p4lang/xUbuntu_22.04  InRelease: The following signatures were invalid: EXPKEYSIG A4666B6753C0F7D1 home:p4lang OBS Project <home:p4lang@build.opensuse.org>
E: The repository 'http://download.opensuse.org/repositories/home:/p4lang/xUbuntu_22.04  InRelease' is not signed.
Error: Process completed with exit code 100.

@grg grg requested review from fruffy and jafingerhut January 22, 2026 21:23
@fruffy
Copy link
Contributor

fruffy commented Jan 22, 2026

It's the same problem we have here: p4lang/p4c#5421

The package signature needs to be updated... until we fix it we can ignore it.

@grg grg merged commit a4ae255 into p4lang:main Jan 22, 2026
9 of 10 checks passed
@grg grg deleted the gleng/1310 branch January 22, 2026 21:32
@fruffy fruffy mentioned this pull request Jan 23, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fruffy fruffy fruffy approved these changes

@jafingerhut jafingerhut Awaiting requested review from jafingerhut

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cmake: tests directory is built regardless of whether nanomsg is enabled

2 participants

@grg @fruffy