Add condition for saving hidden fields or not#33
Draft
PhilippKuhlmay wants to merge 1 commit intopagemachine:masterfrom
Draft
Add condition for saving hidden fields or not#33PhilippKuhlmay wants to merge 1 commit intopagemachine:masterfrom
PhilippKuhlmay wants to merge 1 commit intopagemachine:masterfrom
Conversation
PhilippKuhlmay
force-pushed
the
ignore_hidden_fields_while_saving
branch
from
2e219be to
d414979
Compare
mbrodala
requested changes
Feb 4, 2022
Member
mbrodala
left a comment
mbrodala
left a comment
There was a problem hiding this comment.
Sorry for the very late response. The change itself sounds useful, can you rebase to the latest state? Notice that we require TYPO3v10+ by now.
| */ | ||
| protected $defaultOptions = [ | ||
| 'finisherVariables' => [], | ||
| 'saveHiddenElements' => true, |
Member
There was a problem hiding this comment.
Suggested change
| 'saveHiddenElements' => true, | |
| 'includeHiddenElements' => true, |
Comment on lines
+117
to
+123
| isset($renderingOptions['_isHiddenFormElement']) | ||
| && $renderingOptions['_isHiddenFormElement'] === true | ||
| ) | ||
| || ( | ||
| isset($renderingOptions['_isReadOnlyFormElement']) | ||
| && $renderingOptions['_isReadOnlyFormElement'] === true | ||
| ) |
Member
There was a problem hiding this comment.
These two are gone with TYPO3v10 which is the minimum TYPO3 version by now.
| * | ||
| * @return array | ||
| */ | ||
| protected function getFormValues(): array |
Member
There was a problem hiding this comment.
A method with this name has been added in the meantime, can you integrate your changes there?
Member
|
Would you like to update your PR as suggested? |
|
pushed a new and updated pull request #229 |
mbrodala
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code includes a condition in the finisher, with wich you can switch between "saving hidden fields" or "don't save hidden fields".
If selected, all hidden form values will be ignored while saving the form in the frontend.