Open
Conversation
… callbacks - Extracts list items into a memoized `SortableListFieldItem` component to prevent unnecessary re-renders of the entire list during interactions. - Wraps `SingleField`, `BlocksField`, and `ObjectField` in `React.memo`. - Implements `useCallback` for `toggleOpen`, `handleDragEnd`, `addItem`, `removeItem`, and `toggleAll` to ensure stable function references. - Significantly improves performance for large lists and complex forms.
… callbacks - Extracts list items into a memoized `SortableListFieldItem` component to prevent unnecessary re-renders of the entire list during interactions. - Wraps `SingleField`, `BlocksField`, and `ObjectField` in `React.memo`. - Implements `useCallback` for `toggleOpen`, `handleDragEnd`, `addItem`, `removeItem`, and `toggleAll` to ensure stable function references. - Significantly improves performance for large lists and complex forms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #338
This PR addresses significant performance lag encountered when interacting with large lists (e.g., reordering items, typing in sub-fields) in the EntryForm.
The Problem
Previously, any state update within the ListField (such as hovering, dragging, or typing) caused a "ripple effect" where every single item in the list would re-render. For lists with complex children (like the Publications or Members sections), this resulted in noticeable UI blocking and lag.
The Solution
I have implemented a standard React performance optimization strategy:
1.Component Extraction & Memoization:
2.Stable Callbacks:
3.Recursive Optimization:
Performance Impact
Technical Notes