Format annotated fields in records#1427
Merged
bulldozer-bot[bot] merged 14 commits intodevelopfrom Oct 7, 2025
Merged
Conversation
Generate changelog in
|
✅ Successfully generated changelog entry!What happened?Your changelog entries have been stored in the database as part of our migration to ChangelogV3. Need to regenerate?Simply interact with the changelog bot comment again to regenerate these entries. |
crogoz
commented
Oct 2, 2025
|
|
||
| public record QuoteRequest( | ||
| int value, | ||
|
|
Contributor
Author
There was a problem hiding this comment.
empty lines are kept in the output, so if people decide to add a line between the parameters, the formatter won't remove them
| @Deprecated | ||
| @JsonValue(name = "something") | ||
| @Schema(description = "US state of the product being quoted", example = "TX") | ||
| RegulatoryState regulatoryState, |
Contributor
Author
There was a problem hiding this comment.
new lines before & after the broken annotated field
CRogers
approved these changes
Oct 7, 2025
|
Released 2.77.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
Annotated fields in records would be formatted the same as the annotated arguments of methods.
While this makes sense for annotated arguments of methods (reasoning in: here) for record parameters, it makes them hard to read:
After this PR
Fixes: #922
Fixes: #1292
We are now reformatting the annotated parameters in records only following the rules:
==COMMIT_MSG==
Format annotated fields in records
==COMMIT_MSG==
Possible downsides?