Skip to content

fix(wabe): some security breach on access to non authorized objects #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
coratgerl merged 1 commit into from
Dec 7, 2025
Merged

fix(wabe): some security breach on access to non authorized objects #272

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/wabe/src/database/DatabaseController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -489,7 +489,7 @@ describe('DatabaseController', () => {
select: { id: true },
})

expect(mockInitializeHook).toHaveBeenCalledTimes(1)
expect(mockInitializeHook).toHaveBeenCalledTimes(2)
expect(mockInitializeHook).toHaveBeenCalledWith({
className: 'TestClass',
context: {
Expand All @@ -501,7 +501,7 @@ describe('DatabaseController', () => {
select: { id: true },
})

expect(mockRunOnSingleObject).toHaveBeenCalledTimes(2)
expect(mockRunOnSingleObject).toHaveBeenCalledTimes(4)
expect(mockRunOnSingleObject).toHaveBeenNthCalledWith(1, {
operationType: hooks.OperationType.BeforeCreate,
})
Expand All @@ -528,7 +528,7 @@ describe('DatabaseController', () => {
select: { id: true },
})

expect(mockInitializeHook).toHaveBeenCalledTimes(1)
expect(mockInitializeHook).toHaveBeenCalledTimes(2)
expect(mockInitializeHook).toHaveBeenCalledWith({
className: 'TestClass',
context: {
Expand All @@ -540,7 +540,7 @@ describe('DatabaseController', () => {
select: { id: true },
})

expect(mockRunOnMultipleObject).toHaveBeenCalledTimes(2)
expect(mockRunOnMultipleObject).toHaveBeenCalledTimes(4)
expect(mockRunOnMultipleObject).toHaveBeenNthCalledWith(1, {
operationType: hooks.OperationType.BeforeCreate,
})
Expand Down
43 changes: 31 additions & 12 deletions packages/wabe/src/database/DatabaseController.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,14 +259,19 @@ export class DatabaseController<T extends WabeTypes> {
{
acl: {
users: {
notContains: { userId },
notContains: {
userId,
},
},
},
},
{
acl: {
roles: {
contains: { roleId, [operation]: true },
contains: {
roleId,
[operation]: true,
},
},
},
},
Expand Down Expand Up @@ -399,6 +404,12 @@ export class DatabaseController<T extends WabeTypes> {
context,
where,
}: CountOptions<T, K>): Promise<number> {
const whereWithACLCondition = this._buildWhereWithACL(
where || {},
context,
'read',
)

const hook = initializeHook({
className,
context,
Expand All @@ -409,7 +420,11 @@ export class DatabaseController<T extends WabeTypes> {
operationType: OperationType.BeforeRead,
})

const count = await this.adapter.count({ className, context, where })
const count = await this.adapter.count({
className,
context,
where: whereWithACLCondition,
})

await hook?.runOnSingleObject({
operationType: OperationType.AfterRead,
Expand Down Expand Up @@ -614,7 +629,7 @@ export class DatabaseController<T extends WabeTypes> {
operationType: OperationType.BeforeCreate,
})

const { id } = await this.adapter.createObject({
const res = await this.adapter.createObject({
className,
context,
select,
Expand All @@ -623,18 +638,20 @@ export class DatabaseController<T extends WabeTypes> {

await hook.runOnSingleObject({
operationType: OperationType.AfterCreate,
id,
id: res.id,
})

if (select && Object.keys(select).length === 0) return null

return this.getObject({
className,
context: contextWithRoot(context),
context: {
...context,
// @ts-expect-error
user: className === 'User' ? res : context.user,
},
select,
id,
// Because if you create an object, exceptionnaly you can read it after creation
_skipHooks: true,
id: res.id,
})
}

Expand Down Expand Up @@ -704,12 +721,14 @@ export class DatabaseController<T extends WabeTypes> {

return this.getObjects({
className,
context,
context: {
...context,
// @ts-expect-error
user: className === 'User' ? data[0] : context.user,
},
select,
// @ts-expect-error
where: { id: { in: ids } },
// Because if you create an object, exceptionnaly you can read it after creation
_skipHooks: true,
first,
offset,
order,
Expand Down
27 changes: 0 additions & 27 deletions packages/wabe/src/database/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,6 @@ import {
type DevWabeTypes,
getAdminUserClient,
getGraphqlClient,
createUserAndUpdateRole,
getAnonymousClient,
} from '../utils/helper'
import { setupTests, closeTests } from '../utils/testHelper'
import type { WabeContext } from '../server/interface'
Expand Down Expand Up @@ -136,31 +134,6 @@ describe('Database', () => {
spyGetObjects.mockClear()
})

it("should return created objects with createObjects event if the user doesn't have access to read the object", async () => {
const rootClient = getGraphqlClient(wabe.config.port)

const { userClient } = await createUserAndUpdateRole({
anonymousClient: getAnonymousClient(wabe.config.port),
port: wabe.config.port,
roleName: 'Client',
rootClient,
})

const res = await userClient.request<any>(gql`
mutation createTests{
createTests(input: {fields: [{name: "test"}]}){
edges {
node {
id
}
}
}
}
`)

expect(res.createTests.edges.length).toEqual(1)
})

it('should return id of a relation if set to true in select on getObject', async () => {
const rootClient = getGraphqlClient(wabe.config.port)

Expand Down
1 change: 0 additions & 1 deletion packages/wabe/src/file/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@ describe('File upload', () => {

formData.append('0', new File(['a'], 'a.text', { type: 'text/plain' }))

console.log('before fetch')
const res = await fetch(`http://127.0.0.1:${port}/graphql`, {
method: 'POST',
body: formData,
Expand Down
7 changes: 6 additions & 1 deletion packages/wabe/src/graphql/resolvers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,13 @@ import {
export const extractFieldsFromSetNode = (
selectionSet: SelectionSetNode,
className: string,
options?: { ignoreClassField?: boolean },
): Record<string, any> => {
const ignoredFields = ['edges', 'node', 'clientMutationId', 'ok']
const shouldIgnoreClassField = options?.ignoreClassField ?? true

if (className) ignoredFields.push(firstLetterInLowerCase(className))
if (shouldIgnoreClassField && className)
ignoredFields.push(firstLetterInLowerCase(className))

return selectionSet.selections?.reduce(
(acc, selection) => {
Expand All @@ -34,7 +37,9 @@ export const extractFieldsFromSetNode = (
//@ts-expect-error
selection.selectionSet,
className,
{ ignoreClassField: false },
)

if (ignoredFields.indexOf(currentValue) === -1)
return {
...acc,
Expand Down
84 changes: 43 additions & 41 deletions packages/wabe/src/hooks/setupAcl.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,6 +248,36 @@ describe('setupAcl', () => {
write: true,
})

await hookObject.addACL('roles', {
// @ts-expect-error
role: 'Client',
read: true,
write: true,
})
},
},
},
{
name: 'SetupACL8',
fields: {
test: {
type: 'String',
},
},
permissions: {
create: {
requireAuthentication: false,
},
read: {
requireAuthentication: false,
},
acl: async (hookObject) => {
await hookObject.addACL('users', {
userId: hookObject.context.user?.id || '',
read: true,
write: true,
})

await hookObject.addACL('roles', {
// @ts-expect-error
role: 'Client',
Expand Down Expand Up @@ -319,9 +349,9 @@ describe('setupAcl', () => {
})

const res = await userClient.request<any>(gql`
mutation createSetupACL {
createSetupACL(input: {fields: {test: "test"}}) {
setupACL {
mutation createSetupACL8 {
createSetupACL8(input: {fields: {test: "test"}}) {
setupACL8 {
id
acl {
users {
Expand All @@ -341,30 +371,23 @@ describe('setupAcl', () => {
`)

// User
expect(res.createSetupACL.setupACL.acl.users[0].userId).toEqual(userId)
expect(res.createSetupACL.setupACL.acl.users[0].read).toEqual(true)
expect(res.createSetupACL.setupACL.acl.users[0].write).toEqual(true)
expect(res.createSetupACL8.setupACL8.acl.users[0].userId).toEqual(userId)
expect(res.createSetupACL8.setupACL8.acl.users[0].read).toEqual(true)
expect(res.createSetupACL8.setupACL8.acl.users[0].write).toEqual(true)

// Role
expect(
await getRoleNameFromId(
res.createSetupACL.setupACL.acl.roles[0].roleId,
res.createSetupACL8.setupACL8.acl.roles[0].roleId,
rootClient,
),
).toEqual('Client')
expect(res.createSetupACL.setupACL.acl.roles[0].read).toEqual(true)
expect(res.createSetupACL.setupACL.acl.roles[0].write).toEqual(true)
expect(res.createSetupACL8.setupACL8.acl.roles[0].read).toEqual(true)
expect(res.createSetupACL8.setupACL8.acl.roles[0].write).toEqual(true)
})

it('should not update acl object if the acl function is not present in permissions in the class', async () => {
const { userClient } = await createUserAndUpdateRole({
anonymousClient,
port,
roleName: 'Client',
rootClient,
})

const res = await userClient.request<any>(gql`
const res = await rootClient.request<any>(gql`
mutation createSetupACL2 {
createSetupACL2(input: {fields: {test: "test"}}) {
setupACL2 {
Expand All @@ -390,14 +413,7 @@ describe('setupAcl', () => {
})

it('should set read and write to false if the null value is provided for users and roles', async () => {
const { userClient } = await createUserAndUpdateRole({
anonymousClient,
port,
roleName: 'Client',
rootClient,
})

await userClient.request<any>(gql`
await rootClient.request<any>(gql`
mutation createSetupACL3 {
createSetupACL3(input: {fields: {test: "test"}}) {
setupACL3 {
Expand Down Expand Up @@ -439,14 +455,7 @@ describe('setupAcl', () => {
})

it('should call acl function if provided', async () => {
const { userClient } = await createUserAndUpdateRole({
anonymousClient,
port,
roleName: 'Client',
rootClient,
})

await userClient.request<any>(gql`
await rootClient.request<any>(gql`
mutation createSetupACL4 {
createSetupACL4(input: {fields: {test: "test"}}) {
setupACL4 {
Expand All @@ -460,14 +469,7 @@ describe('setupAcl', () => {
})

it('should get different role id for read and write if roles are different', async () => {
const { userClient } = await createUserAndUpdateRole({
anonymousClient,
port,
roleName: 'Client',
rootClient,
})

const res = await userClient.request<any>(gql`
const res = await rootClient.request<any>(gql`
mutation createSetupACL5 {
createSetupACL5(input: {fields: {test: "test"}}) {
setupACL5 {
Expand Down
Loading