Add API (method in UserMixin) to enable fine-tuned two-factor requirements #1170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments. Previously, whether two-factor authentication was required was controlled by SECURITY_TWO_FACTOR_REQUIRED and whether the user had recently successfully performed a second factor authentication. This default behavior hasn't changed - but now, all the authentication code calls UserMixin.check_tf_required() which, if overridden in an application, can make the decision any way they want - for example - based on user group. closes #1168
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1170 +/- ##
=======================================
Coverage 98.52% 98.52%
=======================================
Files 40 40
Lines 5008 5023 +15
=======================================
+ Hits 4934 4949 +15
Misses 74 74 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, whether two-factor authentication was required was controlled by SECURITY_TWO_FACTOR_REQUIRED and whether the user had recently successfully performed a second factor authentication. This default behavior hasn't changed - but now, all the authentication code calls UserMixin.check_tf_required() which, if overridden in an application, can make the decision any way they want - for example - based on user group.
Also - improve JSON api by always returned tf_required (true or false). Previously this key was only returned if True.
closes #1168