Skip to content

DOC: Fix spelling mistakes and incomplete sentences in Timestamp docstrings#63955

Merged
rhshadrach merged 5 commits intopandas-dev:mainfrom
vishwas-droid:doc-grammar-fix-clean
Feb 9, 2026
Merged

DOC: Fix spelling mistakes and incomplete sentences in Timestamp docstrings#63955
rhshadrach merged 5 commits intopandas-dev:mainfrom
vishwas-droid:doc-grammar-fix-clean

Conversation

@vishwas-droid
Copy link
Contributor

This PR fixes a couple of clear spelling mistakes and a few incomplete or
awkwardly phrased sentences in Timestamp-related docstrings.
These are documentation-only changes and do not affect any behavior or logic.

@vishwas-droid
Copy link
Contributor Author

@rhshadrach Could you take a look at this and share your thoughts when you have a moment?
Thanks!

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! The pr-commit build needs to be passing.

@rhshadrach rhshadrach added Docs Timestamp pd.Timestamp and associated methods labels Jan 30, 2026
@vishwas-droid
Copy link
Contributor Author

@rhshadrach I've addressed the feedback and everything is in place now. Happy to move forward whenever it looks good to you. Thanks!

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach added the Error Reporting Incorrect or improved errors from pandas label Jan 31, 2026
@rhshadrach rhshadrach added this to the 3.1 milestone Jan 31, 2026
@vishwas-droid
Copy link
Contributor Author

Thanks a lot for the review and approval! I really appreciate it.

@rhshadrach
Copy link
Member

@vishwas-droid - looks like the tests need update due to the change in the error message.

@vishwas-droid
Copy link
Contributor Author

@rhshadrach Updated the tests to match the revised error message and the Timestamp wording.

@rhshadrach
Copy link
Member

@vishwas-droid the failure of test_parsing_tzlocal_deprecated looks related.

@vishwas-droid
Copy link
Contributor Author

vishwas-droid commented Feb 1, 2026

@rhshadrach
I really appreciate the quick help. I’ve aligned test_parsing_tzlocal_deprecated with the updated "unrecognized timezone" message. I think CI should be green now. Otherwise , I think this is ready to merge. Let me know if any changes are needed.

Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rhshadrach rhshadrach merged commit d19808b into pandas-dev:main Feb 9, 2026
41 of 42 checks passed
@rhshadrach
Copy link
Member

Thanks @vishwas-droid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Docs Error Reporting Incorrect or improved errors from pandas Timestamp pd.Timestamp and associated methods

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants