DOC: Fix PANDAS_VERSION in docs build #64013
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/preview |
Contributor
|
Website preview of this PR available at: https://pandas.pydata.org/preview/pandas-dev/pandas/64013/ |
Member
Author
|
I'm not familiar with how the banner works, I'm still not seeing the dev banner here. |
| if [ -n "${{ github.event.inputs.version }}" ]; then | ||
| echo "PANDAS_VERSION=${{ github.event.inputs.version }}" >> "$GITHUB_ENV" | ||
| else | ||
| elif [[ "${GITHUB_REF_NAME:1}" =~ ^[0-9]+\.[0-9]+\.[0-9]+$ ]]; then |
Member
There was a problem hiding this comment.
Will that allow rc versions? (those get currently uploaded)
i.e. anytime that the if check passes in the "Upload prod docs" step, we should have a value set for PANDAS_VERSION (not fully sure if it would otherwise error, or fill in an empty string and upload the docs to the wrong directory)
Member
I forgot to answer about that on the issue, but that is unrelated, and just explicitly disabled in our conf.py |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.We should only set the pandas version when the ref matches a valid SemVer string.