-
Notifications
You must be signed in to change notification settings - Fork 5
feat: Add Spanish translation (es) #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughAdds Spanish locale support: imports date-fns/es, registers "es" in the locales array and dateFnsLocales map, adds Spanish labels to existing message files, and introduces a new comprehensive Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Important Action Needed: IP Allowlist UpdateIf your organization protects your Git platform with IP whitelisting, please add the new CodeRabbit IP address to your allowlist:
Reviews will stop working after February 8, 2026 if the new IP is not added to your allowlist. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@messages/es.json`:
- Around line 1-817: The reviewer asks you to run the i18n validation to ensure
all locale files are synchronized; run the CLI command `npm run i18n`, inspect
the output for missing/unused keys across messages/en.json and messages/it.json
(and any other locales), add or remove keys or update translations to restore
parity with messages/es.json/messages/de.json, re-run `npm run i18n` until it
reports no errors, then commit the updated locale files and the i18n validation
results.
|
Hi @panteLx, this PR adds Spanish translations. Please consider merging and updating the Docker image so the new locale is available to users. Thank you! |
disgran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
README.md
This pull request adds support for Spanish in BetterShift.
Changes included:
Added messages/es.json
Updated messages/en.json, messages/it.json, messages/de.json
Updated lib/locales.ts to register the new es locale
Notes:
Only translation files and locale registration were modified.
No changes were made to the Dockerfile, npm configuration, or build process.
If this contribution fits the project roadmap, I would appreciate it if you could merge it and include the Spanish language in the official project, as well as rebuild and update the Docker image so the new locale is available to users.
Summary by CodeRabbit