[SITE-5266] perf: Move kint-php/kint to dev dependencies to eliminate production overhead #231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moves kint-php/kint from runtime dependencies to dev dependencies - Removes duplicate kint entry from suggest section - Prevents ~27ms execution overhead and ~3MB memory usage per request in production - Kint's composer metadata parsing runs before Drupal caching can help - Only affects production environments with --no-dev installs - Development environments retain full Kint debugging functionality Resolves performance bottleneck where Kint parses 300+ package metadata from composer/installed.json on every request for debugging functionality that should not be present in production.
pwtyler
changed the title
Member
|
Hi @paulsheldrake, thanks for the PR— We've actually got an overhaul (#230) of search_api_pantheon that includes removing kint as a dependency entirely. At the moment It's actually called in a couple of commands in (Diagnose.php and TestIndexAndQuery.php) even thought it really shouldn't, so just moving it to dev deps would break the current exception handling. Hoping to get that PR in and the major version published soon, it got sidelined for a bit but we're back on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR moves from runtime dependencies () to development dependencies () to eliminate significant performance overhead in production environments.
Problem
Kint is currently loaded on every request in production, causing:
This overhead occurs because Kint's file automatically parses and files to look for configuration, which happens during Composer's autoload process on every request.
Solution
Impact
Production (with )
✅ Eliminates ~27ms + 3MB overhead per request
✅ No functionality loss (Kint shouldn't be in production)
✅ Faster page loads and reduced memory usage
Development (with dev dependencies)
✅ Kint remains fully available for debugging
✅ No breaking changes to development workflow
✅ All existing functionality preserved
Testing
Performance Evidence
This change addresses a performance bottleneck identified via XDebug profiling where Kint's JSON parsing of composer metadata was consuming significant resources on every request before any application-level caching could help.
Breaking Changes
None for typical usage. Only affects environments that:
Such usage would be incorrect anyway as debugging tools shouldn't be used in production.