Open
Conversation
nicolas-brousse
requested review from
Spone and
nicolas-brousse
and removed request for
Spone
Collaborator
|
Great! Can you please add a changelog entry? Also, can we add a test that uses this new behavior? |
Collaborator
|
@woller can you rebase? We fixed CI in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of hard coding
:useras the object name in the supplied test_helper, this PR checks if the class of the object passed toform_withresponds tomodel_nameand uses the param key from there. If it does not respond, it defaults to user.