Conversation
add homGP wrapper and test
Add option to predict nugget term only
Collaborator
|
@ozgesurer these look good to me! I did put some changes to some of the test functions in #27 so to add some numerical stability to the unit tests (so they should pass more robustly) I also ran the examples and they all worked for me! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@davidogara
Could you please go through the instructions to check that everything runs smoothly?
Note that I did not list hetGPy in requirements.txt. Instead, I included an instruction to install it directly from GitHub, since that should give the most up-to-date version.
Please let me know if you run into any errors or issues.