Skip to content

fix: Default HTML pages for password reset, email verification not found#10034

Open
mtrezza wants to merge 1 commit intoparse-community:alphafrom
mtrezza:fix/default-pages-router
Open

fix: Default HTML pages for password reset, email verification not found#10034
mtrezza wants to merge 1 commit intoparse-community:alphafrom
mtrezza:fix/default-pages-router

Conversation

@mtrezza
Copy link
Member

@mtrezza mtrezza commented Feb 4, 2026

Pull Request

Summary by CodeRabbit

  • New Features

    • Added support for asynchronously resolved server URLs, enabling dynamic configuration in password reset and email verification flows.
  • Chores

    • Updated package distribution file structure.

@parse-github-assistant
Copy link

parse-github-assistant bot commented Feb 4, 2026

🚀 Thanks for opening this pull request!

@parseplatformorg
Copy link
Contributor

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai
Copy link

coderabbitai bot commented Feb 4, 2026

📝 Walkthrough

Walkthrough

This pull request converts PagesRouter.setConfig from synchronous to asynchronous to support dynamic configuration loading. The package export path is updated from public_html/ to public/, and tests are added to verify async publicServerURL behavior in password reset and email verification flows.

Changes

Cohort / File(s) Summary
Package Configuration
package.json
Updated published files list entry from public_html/ to public/ directory reference.
PagesRouter Implementation
src/Routers/PagesRouter.js
Converted setConfig method to async, enabling config-key loading on demand. All route handlers updated to return promises from setConfig invocations to propagate asynchrony.
PagesRouter Tests
spec/PagesRouter.spec.js
Added test suite for async publicServerURL scenarios, verifying password reset and email verification flows correctly handle asynchronously resolved server URLs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~15 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is incomplete and missing critical required sections. Add the Issue section with the issue reference, Approach section describing the changes, and Tasks section with relevant items checked or removed.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately reflects the main change: fixing default HTML pages for password reset and email verification endpoints.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Feb 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.55%. Comparing base (6cfbcfd) to head (ac4c9cc).

Additional details and impacted files
@@           Coverage Diff           @@
##            alpha   #10034   +/-   ##
=======================================
  Coverage   92.54%   92.55%           
=======================================
  Files         190      190           
  Lines       15489    15490    +1     
  Branches      176      176           
=======================================
+ Hits        14335    14337    +2     
+ Misses       1142     1141    -1     
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

requestPasswordReset email link (“Verify Email” button) redirects to Not Found

2 participants