Adding folder structure to export for Keepass#73
Open
gyaresu wants to merge 1 commit intopassbolt:mainfrom
Open
Adding folder structure to export for Keepass#73gyaresu wants to merge 1 commit intopassbolt:mainfrom
gyaresu wants to merge 1 commit intopassbolt:mainfrom
Conversation
Collaborator
|
Hi, thanks for the PR, Currently there are some bigger changes inflight for supporting v5 encrypted metadata passbolt/go-passbolt#23 . Due to those there will be some API changes which breaks a few things things around go-passbolt-cli including the Export. Because of that this PR will have to wait till that is finished. In the meantime i took a quick look at the PR, here are some of the issues i found:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caveat: I am not a regular Go programmer and I provide this in hope that it provides some utility to folks.
PR: Add Folder Structure Support to Keepass Export
Description
This PR adds folder structure support to Keepass exports, maintaining the folder hierarchy from Passbolt when exporting to a Keepass (.kdbx) file. Previously, resources were exported to a flat structure.
Changes
Features Supported
Testing
Tested with:
Compatibility