Conversation
|
Hi @sbabiv, This repository seems to have gone stale and I am going to keep the go-cache running, I have added your PR if you are interested. |
paddlesteamer
suggested changes
Jun 23, 2020
paddlesteamer
left a comment
There was a problem hiding this comment.
I think it is problematic. I'm worried about this (edge) case:
- we get the item, check the expiration, it is almost expired but not expired yet
- we do read unlock
- onEvicted wins the race condition and do something because it thinks the item is expired
- then we do write lock and reset the item
so it's not atomic. It may cause problems when it's used with user-provided onEvicted function.
I think to complete this completely the items should have their own mutexes and the changes inside of the items (like change in Expiration) shouldn't be considered in cache's write lock scope.
This was referenced Jul 2, 2020
Repository owner
deleted a comment from
pablodz
Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In many cases, it is convenient to get items with an updated cache lifetime.