Skip to content

Comments

Fix: Resolve deprecation warnings#6

Merged
pawelpesz merged 1 commit intopawelpesz:mainfrom
watford-ep:resolve-tf-warnings
Aug 1, 2025
Merged

Fix: Resolve deprecation warnings#6
pawelpesz merged 1 commit intopawelpesz:mainfrom
watford-ep:resolve-tf-warnings

Conversation

@watford-ep
Copy link

@watford-ep watford-ep commented Jul 15, 2025

This PR addresses a warnings received when I imported your module:

╷
│ Warning: Invalid Attribute Combination
│ 
│   with module.remote_state.aws_s3_bucket_lifecycle_configuration.state,
│   on .terraform/modules/remote_state/bucket.tf line 110, in resource "aws_s3_bucket_lifecycle_configuration" "state":
│  110: resource "aws_s3_bucket_lifecycle_configuration" "state" {
│ 
│ No attribute specified when one (and only one) of [rule[0].filter,rule[0].prefix] is required
│ 
│ This will be an error in a future version of the provider
│ 
│ (and one more similar warning elsewhere)
╵

@watford-ep
Copy link
Author

Fair enough! Didn't know when/if you were taking a major bump.

@watford-ep watford-ep closed this Aug 1, 2025
@pawelpesz
Copy link
Owner

Hey @watford-ep, the other change (adding the filter element) wasn't a problem, it's compatible with the older versions of the AWS provider. I would be happy to merge it in 😄

@watford-ep watford-ep reopened this Aug 1, 2025
@pawelpesz
Copy link
Owner

One more thing @watford-ep, could you follow the conventional commits convention, so that the release notes are generated correctly? See the commits for examples of what is expected: https://github.com/pawelpesz/terraform-aws-remote-state-s3-backend-v2/commits/main/. Cheers!

│ Warning: Invalid Attribute Combination
│
│   with module.remote_state.aws_s3_bucket_lifecycle_configuration.replica,
│   on ../../replica.tf line 222, in resource "aws_s3_bucket_lifecycle_configuration" "replica":
│  222: resource "aws_s3_bucket_lifecycle_configuration" "replica" {
│
│ No attribute specified when one (and only one) of [rule[0].filter,rule[0].prefix] is required
│
│ This will be an error in a future version of the provider
╵
@watford-ep watford-ep force-pushed the resolve-tf-warnings branch from 8fdd7fc to b0edc0b Compare August 1, 2025 14:33
@watford-ep
Copy link
Author

@pawelpesz handled

@pawelpesz pawelpesz merged commit ac55ef6 into pawelpesz:main Aug 1, 2025
2 checks passed
@pawelpesz
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants