Fix of versions fail in 3.2.0#20
Merged
mSprunskas merged 7 commits intopaysera:masterfrom Nov 27, 2025
Merged
Conversation
mSprunskas
reviewed
Nov 19, 2025
|
|
||
| $message = new Message(); | ||
|
|
||
| //region Timestamp conversion for gelf-php v2.0 strict typing |
Contributor
There was a problem hiding this comment.
is this all copy-paste because of datetime handling?
Contributor
Author
There was a problem hiding this comment.
yes, and for this block below
//region setFacility/setLine/setFile replaced with setAdditional
Contributor
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
Ok, lets do following:
- lets move GelfMessageFormatter code blocks that require modification to private methods, it's better way than comments to deduce what parts were overiden
- lets move FormatterTrait inside NormalizeCompatibilityTrait, this will reduce complexity as \Paysera\LoggingExtraBundle\Service\Formatter\FormatterTrait::normalizeWithPrenormalization is only used in \Paysera\LoggingExtraBundle\Service\Formatter\NormalizeCompatibilityTrait
mSprunskas
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.