Skip to content

Conversation

@LasneF
Copy link
Contributor

@LasneF LasneF commented Dec 13, 2024

fix issues #347
#348

@@ -0,0 +1,10 @@
{
// Use IntelliSense to learn about possible attributes.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file needs to be removed

@codecov
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (a043870) to head (d6ec814).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #358   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files         165      165           
  Lines       21122    21145   +23     
=======================================
+ Hits        21028    21051   +23     
  Misses         89       89           
  Partials        5        5           
Flag Coverage Δ
unittests 99.55% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LasneF
Copy link
Contributor Author

LasneF commented Dec 26, 2024

file dropped , sorry , it may be usefull to add a .gitignore should i add one in a different PR ?

Copy link
Member

@daveshanley daveshanley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@daveshanley daveshanley merged commit f79329e into pb33f:main Jan 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants