Skip to content

WIP: Test to show bundling failure with embeded directory#498

Draft
pete-woods wants to merge 1 commit intopb33f:mainfrom
pete-woods:bundle-embdedded
Draft

WIP: Test to show bundling failure with embeded directory#498
pete-woods wants to merge 1 commit intopb33f:mainfrom
pete-woods:bundle-embdedded

Conversation

@pete-woods
Copy link

No description provided.

@daveshanley
Copy link
Member

Your approach is right, the failing test needs to be updated.

                         |
                    LocalFS (fs.FS)
                         |
                         v
          +-------- Type Check --------+
          |                            |
          v                            v
    RolodexFS?                  Generic fs.FS?
          |                            |
          v                            v
     Use directly              Wrap in LocalFS
          |                            |
          +------------+---------------+
                       |
                       v
            rolodex.AddLocalFS(cwd, localFS)

this is the flow. the test needs fixing.

Update the v3 test - Change assert.Error(t, err) to assert.NoError(t, err)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants