WIP: Test to show bundling failure with embeded directory#498
Draft
pete-woods wants to merge 1 commit intopb33f:mainfrom
Draft
WIP: Test to show bundling failure with embeded directory#498pete-woods wants to merge 1 commit intopb33f:mainfrom
pete-woods wants to merge 1 commit intopb33f:mainfrom
Conversation
05b7f9c to
592610d
Compare
592610d to
9f956c5
Compare
Member
|
Your approach is right, the failing test needs to be updated. this is the flow. the test needs fixing. Update the v3 test - Change assert.Error(t, err) to assert.NoError(t, err) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.