Fixed formatting of time strings without seconds#18
Open
mbgonicus wants to merge 1 commit intopbnjay:mainfrom
Open
Fixed formatting of time strings without seconds#18mbgonicus wants to merge 1 commit intopbnjay:mainfrom
mbgonicus wants to merge 1 commit intopbnjay:mainfrom
Conversation
When creating a formatter with the format "hh:mm", then makeFormatters will not detect the "mm" as minutes, but as months, and will therefore create an incorrect output. For example, the 22nd November at the time 13:37 will produce "13:11" instead of "13:37", as expected. This commit adds a unit test for the errornous case and a fix for the regular expression that detects a time string. Now, seconds are optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating a formatter with the format "hh:mm", then makeFormatters will not detect the "mm" as minutes, but as months, and will therefore create an incorrect output. For example, the 22nd November at the time 13:37 will produce "13:11" instead of "13:37", as expected.
This commit adds a unit test for the errornous case and a fix for the regular expression that detects a time string. Now, seconds are optional.
It is probably a good idea to rethink the regex, as it might produce more errors.