Open
Conversation
|
How about this :) console-client/pCloudCC/lib/pclsync/plibs.h Lines 58 to 60 in 2ecb7c9 As well as: |
Author
|
@sergeyklay thanks for addressing this PR. :) Do you suggest using those macros instead of logging to syslog? |
|
@Cvetomird91 I mean, this PR don't completely cover the idea of logging and actually just add +1 place where the logs might be. It would be better to either get rid of the files altogether, or write only to files (in terms of consistency and program design). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
I noticed that the pCloud console client didn't log messages to the Linux logging facility. I used syslog.h to add this functionality. I tested it on Fedora 25, which directly logs the messages to the systemd logging facility.