Conversation
|
It looks like pyreadline3 PR #9 might fix the color completions bug. If we can get that merged, we can remove that note from this readme. |
|
@parejkoj ohhh i got it. even though we install pyreadline3 via |
|
@athrvvvv : I'm not sure about that. It certainly looks like pyreadline3 should be imported as exactly that. The thing I don't know how to do is test it. |
|
The import is wrapped internally and it looks like what it is imported as doesn't matter, e.g., no need for Unless you're saying the import has to be |
|
To get this merged CI should be green, which involves moving it to GitHub Actions (#46). Then there might also a compat issue, given that "Version 3.4+ or pyreadline3 runs on Python 3.5+.". |
|
can we get this PR merged please? |
I updated the pyreadline dependency, import, and readme links. I'm not sure how to test that this will pip-install with the correct dependency, though.
There's also some further discussion in the readme about bugs in the current pyreadline (e.g. issue 48); there aren't specific issue links to convert those to, and I don't know which, if any, of those bugs have been fixed in pyreadline3.
This should fix issues #36 and #37 .