Open
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Member
Author
|
I rushed the code a bit using gemini, but I did rewrite the search result ranking part to mimic what we did on lrclib. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
JellyBrick
requested changes
Dec 19, 2025
| // Code adapted from https://greasyfork.org/en/scripts/548724-youtube-music-spotify-%E7%BD%91%E6%98%93%E4%BA%91%E6%AD%8C%E8%AF%8D%E6%98%BE%E7%A4%BA | ||
| // which is licenced under the MIT licence | ||
|
|
||
| import CryptoJS from 'crypto-js'; |
Collaborator
There was a problem hiding this comment.
I think we can avoid using CryptoJS.
We might be able to achieve this using native APIs (like Web Crypto API or Node's crypto module).
Member
Author
There was a problem hiding this comment.
web crypto would be a pain to use, and node's crypto would require context switching via IPC
and I was too lazy to do that
but if you insist, then I am all for it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #4059
Notes: NetEase's search algorithm is a bit rough