feat(transparent-player): Added Linux and macOS support#4199
Open
its-iris wants to merge 4 commits intopear-devs:masterfrom
Open
feat(transparent-player): Added Linux and macOS support#4199its-iris wants to merge 4 commits intopear-devs:masterfrom
its-iris wants to merge 4 commits intopear-devs:masterfrom
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the transparent-player plugin to support Linux and macOS platforms, which was previously Windows-only. The changes introduce platform-specific material types and refactor the code into separate files for better organization.
Changes:
- Added macOS vibrancy material types (WINDOW, FULLSCREEN_UI, CONTENT, UNDER_WINDOW, UNDER_PAGE) to the MaterialType enum
- Refactored plugin code into separate menu.ts and backend.ts files with platform-specific logic
- Added Linux-specific initialization code in src/index.ts to enable transparency support with required command-line switches
- Removed Platform.Windows restriction to allow the plugin to work on all platforms
- Changed default material type from ACRYLIC to NONE for cross-platform compatibility
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| src/plugins/transparent-player/types.ts | Added macOS-specific material type enum values and reorganized the enum with comments |
| src/plugins/transparent-player/menu.ts | New file containing platform-specific menu logic that filters material types based on the operating system |
| src/plugins/transparent-player/index.ts | Refactored to extract menu and backend logic to separate files; removed Windows platform restriction and changed default config |
| src/plugins/transparent-player/backend.ts | New file containing backend logic with platform-specific window material handling for Windows (setBackgroundMaterial) and macOS (setVibrancy) |
| src/index.ts | Added Linux-specific configuration for transparent-player plugin, including required command-line switches and hardware acceleration handling |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5 tasks
Member
|
Does this plugin support freebsd? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.