[2.x] Adds the stress function for declaring stress tests#16
Open
lukeraymonddowning wants to merge 1 commit into2.xfrom
Open
[2.x] Adds the stress function for declaring stress tests#16lukeraymonddowning wants to merge 1 commit into2.xfrom
stress function for declaring stress tests#16lukeraymonddowning wants to merge 1 commit into2.xfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Much like the PR to the Arch plugin, this PR adds the
stressfunction as a top level test creator that also marks the test as being part of thestressgroup, allowing the user (and Pest) to easily only run stress tests or exclude stress tests.The problem with this plugin is that we already declare the
stressfunction to start a stress test. I handle this in the following way:stressnow accepts two parameters. If only one is passed, it acts as it did before. If both are passed, it acts as atestfunction.visit, which performs the same functionality thatstressdid previously. Thestressfunction now callsvisitunder the hood.My hope is that we can encourage users to make use of
visitinstead ofstressinside the test closure itself, although obviously what I've added here is still fully backwards compatible. Obviously I'm also open to other approaches here.Kind Regards,
Luke