:math.pow can't handle arbitrarily-large integers#5
Open
DoggettCK wants to merge 1 commit intopetermueller:masterfrom
DoggettCK:support-bigger-integers
Open
:math.pow can't handle arbitrarily-large integers#5DoggettCK wants to merge 1 commit intopetermueller:masterfrom DoggettCK:support-bigger-integers
DoggettCK wants to merge 1 commit intopetermueller:masterfrom
DoggettCK:support-bigger-integers
Conversation
`:math.pow` and `Enum.random` both fail when `opts.size` hits 309, limiting how large an integer size you can generate. Used a custom `pow` implementation that will support arbitrarily-large ints, then passing those to `:crypto.rand_uniform`, which should avoid those limitations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:math.powandEnum.randomboth fail whenopts.sizehits 309, limitinghow large an integer size you can generate. Used a custom
powimplementation that will support arbitrarily-large ints, then passing
those to
:crypto.rand_uniform, which should avoid those limitations.