Fix #9572: Deployment of helm chart crashing with operation not permitted#9574
Open
simonra wants to merge 1 commit intopgadmin-org:masterfrom
Open
Fix #9572: Deployment of helm chart crashing with operation not permitted#9574simonra wants to merge 1 commit intopgadmin-org:masterfrom
simonra wants to merge 1 commit intopgadmin-org:masterfrom
Conversation
…n not permitted The root cause appears to be that the base image has moved the location of python from /usr/bin/ to /usr/local/bin/. This prevented the workaround done by the init containers copying out the binary with the users permissions from working.
WalkthroughUpdates Python binary paths in a Helm deployment template for the pgadmin4 container. One volumeMount path and one init container binary search path are changed to reference alternate Python binary locations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@pkg/helm/templates/deployment.yaml`:
- Line 208: Update the args entry that selects and copies the Python binary:
narrow the glob from python3.* to python3.[0-9][0-9] to avoid matching
non-binaries, and add explicit failure handling so the container fails loudly if
no matching binary is found (e.g., run the pipeline with pipefail/set -e or
check the ls result and echo an error + exit 1 when empty) before attempting to
cp; locate this change in the args: [...] line that currently contains "ls
/venv/bin/python3.* | sort -V -r | head -n 1 | xargs -i cp {} python3" and
replace it with the stricter glob and an explicit non-zero exit path on
no-match.
|
Tested and works great, hopefully we get this released soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause appears to be that the base image has moved the location of python from
/usr/bin/to/usr/local/bin/. This prevented the workaround done by the init containers copying out the binary with the users permissions from working.Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.