fix: race condition with Sequelize, feat: support multiple SET statements in one query #760
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Race condition fix
Fixes race condition with sequelize and other similar ORMs that do the following:
We treated this as query is finished and let our pool logic send
Syncasynchronously as a cleanup step. Meanwhile, Sequelize would sendSyncseparately and we would immediately returnReadyForQuery, but the cleanup is async and would happen after we responded withReadyForQuery. The client then thought a record was created before it was actually saved in Postgres. This is a likely fix for #685 cc @mkreidenweis-schulmngrMultiple
SETstatementsSequelize also sends multiple
SETcommands in one query. We handle this now correctly, although it's not related to the race condition.