Fix missing digits // Better OTA // Improved WeatherPlugin

[yourdawi]

I removed Screen.loadFromStorage() out of Messages_::scroll() because persist() already saves the state. And the loop of the Plugin renders it with the next iteration again.

Fixed missing digits in Clock #154

OTA was not working for me, changed a bit to make it work perfectly.

I run into some issues with the WeatherPlugin (not loading, crashing esp) so i made some improvements.

[Solmath]

Hi @yourdawi,

thanks a lot for the contribution! I just implemented the changes to message handling in my develop branch and would like to provide some feedback (see other comments).

One small suggestion for future PRs: Since this contains three independent changes, it might be helpful to split them into separate PRs. This can make it easier for maintainers to review and merge changes independently, but of course that's up to you and the maintainers' preferences.

Thanks again, and @HennieLP might also find this interesting.

Cheers

[Solmath]

This could be moved to a function, because it is used twice (e.g. restoreScreenIfMessagesEmpty())

[Solmath]

If loadFromStorage is removed in favor of using the cache, will persist() still be necessary?

As far as I understand persist() will save the screen content to non-volatile memory, while the cache lives in the RAM. The only other location where perist() is used is the DrawPlugin.

I'm a bit confused.

[yourdawi]

It would be possible to remove persist(), its needed for saving to flash (brightness, renderBuffer_, rotation).
With only cacheCurrent() and restoreCache(), it would be gone after a restart, What is mostly needed for Draw i think.

[Solmath]

I wrote it like this to have fewer nested conditions:

if (currentStatus == NONE)
{
  Scheduler.update();
}

if (currentStatus == NONE || currentStatus == MESSAGES)
{
  if ((taskCounter % 4) == 0)
  {
    Messages.scrollMessageEveryMinute();
  }
}

[yourdawi]

One small suggestion for future PRs: Since this contains three independent changes, it might be helpful to split them into separate PRs. This can make it easier for maintainers to review and merge changes independently, but of course that's up to you and the maintainers' preferences.

The truth is, i do not know how to make multiple PRs, everything i pushed in my fork, was in this PR. :/

[mrueg]

One small suggestion for future PRs: Since this contains three independent changes, it might be helpful to split them into separate PRs. This can make it easier for maintainers to review and merge changes independently, but of course that's up to you and the maintainers' preferences.

The truth is, i do not know how to make multiple PRs, everything i pushed in my fork, was in this PR. :/

Git has the concept of branches. The main one usually has the name main or before that master.
You can create multiple branches in git with git checkout -b my-new-branch.
Then you commit the desired changes towards that branch and push it to your fork in github. After that you can use that branch to create a PR for a specific feature.