Remove standalone PointFinder support #98
Merged
fmaguire merged 14 commits intopha4ge:masterfrom Jan 3, 2025
Merged
Conversation
- PointFinder is now integrated in ResFinder - The code in the repo of the standalone tool is stale
zwets
force-pushed
the
point-to-resfinder
branch
from
56cc12d to
2127e9a
Compare
Member
|
Amazing work @zwets, really appreciate your efforts! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes support for the standalone PointFinder tool. Important: and includes PR #97 and #96 so pulls in the AFP upgrade as well (sorry, got my branches tangled up).
Rationale: PointFinder been integrated in ResFinder, and the code in the standalone PointFinder repo is now stale. I have asked the maintainers to mark it deprecated and point people at ResFinder.
PS: perhaps add a CHANGELOG file to the repo?