Added "refresh" feature, and a few missing but known attributes, and improved the documentation slightly#4
Open
kfatehi wants to merge 3 commits intopheinrichs:masterfrom
Open
Added "refresh" feature, and a few missing but known attributes, and improved the documentation slightly#4kfatehi wants to merge 3 commits intopheinrichs:masterfrom
kfatehi wants to merge 3 commits intopheinrichs:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
Thanks for this nice and simple MNDP implementation. I needed a "refresh" functionality so I implemented that in your library.
I also brought in some more attributes (from wireshark's mndp dissector) into your parser.
I also noticed that the usage instructions were outdated because the library does not export the class directly, so I have updated the readme to match your actual convention (as you use in test.js and I witnessed is also used in prometheus' usage of your library over on https://github.com/patagonaa/prometheus-mndp-autodiscovery/blob/master/src/index.js).
In addition I have documented the refresh function and additional attributes that I've added.
Thanks!