Open
Conversation
philss
reviewed
Dec 19, 2025
| defp get_value(attr_name, attributes) do | ||
| Enum.find_value(attributes, "", fn | ||
| defp get_value(attr_name, attributes) when is_list(attributes) do | ||
| case List.keyfind(attributes, attr_name, 0) do |
Owner
There was a problem hiding this comment.
How much of the improvements came from this change?
If is not that much, I would prefer to keep the Enum.find_value/3 just because it's easier to read and maintain.
Contributor
Author
There was a problem hiding this comment.
I just ran the benchmarks back and forth changing this part only and it's faster in all cases, the biggest win in speedup is that it's ~11% faster in the "exact_attribute" case but most significantly it halves the memory usage in the "exact_attribute" and in the "attribute_includes" cases.
I believe this library is used heavily by a lot of companies where every speedup has a huge effect on throughput.
That is the case for our company.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
exact attribute => ~5% faster, ~50% lower memory usage
attribute present => ~10% faster, ~40% lower memory usage
attribute includes => ~100% faster, ~60% lower memory usage
This change utilizes more built in functions instead of
Enumand usesString.contains?to check for match before performingString.split.